Enhance Tests: button-copy #6301
Open
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dlockhart
reviewed
Nov 18, 2025
|
|
||
| describe('icon state', () => { | ||
|
|
||
| it('clears previous timeout on multiple clicks', async() => { |
Member
There was a problem hiding this comment.
This feels like a somewhat fragile way to test that clicking the copy button multiple times extends the amount of time before clearing the copied icon. I wonder if we could do a vdiff with a fake timer (so we're not actually waiting 2s) that accomplishes the same thing?
| await waitUntil(() => { | ||
| const buttonIcon = elem.shadowRoot.querySelector('d2l-button-icon'); | ||
| return buttonIcon.icon === 'tier1:copy'; | ||
| }, 'icon did not revert to copy', { timeout: 3000 }); |
Member
There was a problem hiding this comment.
Instead of actually waiting 3s, could we use Sinon's fake time to manually advance the clock?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira task
Adds tests based on suggestions from CoPilot. I did remove the suggested disabled and focus state vdiffs due to prior discussion about how that has overlap with button-icon vdiffs.